[flutter_tools] flutter logs no longer requires supported device #66696
Conversation
| @@ -428,7 +435,7 @@ abstract class PollingDeviceDiscovery extends DeviceDiscovery { | |||
|
|
|||
| Future<List<Device>> pollingGetDevices({ Duration timeout }); | |||
|
|
|||
| Future<void> startPolling() async { | |||
| void startPolling() { | |||
jonahwilliams
Sep 25, 2020
Author
Member
Most of these methods do not need to be async - this made it much easier to fix the disabled test
| @@ -66,7 +66,7 @@ class DaemonCommand extends FlutterCommand { | |||
|
|
|||
| typedef DispatchCommand = void Function(Map<String, dynamic> command); | |||
jonahwilliams
Sep 28, 2020
Author
Member
These changes just make the async APIs sync like the underlying code
| @@ -34,7 +34,7 @@ class LogsCommand extends FlutterCommand { | |||
|
|
|||
| @override | |||
| Future<FlutterCommandResult> verifyThenRunCommand(String commandPath) async { | |||
| device = await findTargetDevice(); | |||
| device = await findTargetDevice(includeUnsupportedDevices: true); | |||
| @@ -138,26 +138,26 @@ void main() { | |||
| }); | |||
|
|
|||
| group('PollingDeviceDiscovery', () { | |||
| testUsingContext('startPolling', () async { | |||
| await FakeAsync().run((FakeAsync time) async { | |||
| testUsingContext('startPolling', () { | |||
|
@Hixie as the primary user of |
| @@ -66,7 +66,7 @@ class DaemonCommand extends FlutterCommand { | |||
|
|
|||
| typedef DispatchCommand = void Function(Map<String, dynamic> command); | |||
|
|
|||
| typedef CommandHandler = Future<dynamic> Function(Map<String, dynamic> args); | |||
| typedef CommandHandler = FutureOr<dynamic> Function(Map<String, dynamic> args); | |||
Hixie
Oct 2, 2020
Member
FWIW, I would strongly prefer we never use FutureOr. It leads to all kinds of issues later.
|
LGTM module the FutureOr. But I suspect that means something else major has to change...? |
|
Fixed the FutureOr issue :) , NBD |
|
Landing to kick the tree - the last red test passed but the build status is stuck |
jonahwilliams
merged commit 1bea512
into
flutter:master
25 of 26 checks passed
25 of 26 checks passed
flutter-build
Flutter build is currently broken. Please do not merge this PR unless it contains a fix to the broken build.
Details
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Flutter logs should not attempt to filter the device list based on the current project, because it does not require a current project. Also fix disabled polling test
Fixes #47996
Fixes #63550