Refactor MSI code to make it easier to add a WiX EXE installer#13139
Merged
TravisEz13 merged 19 commits intoPowerShell:masterfrom Jul 10, 2020
Merged
Refactor MSI code to make it easier to add a WiX EXE installer#13139TravisEz13 merged 19 commits intoPowerShell:masterfrom
TravisEz13 merged 19 commits intoPowerShell:masterfrom
Conversation
ghost
assigned
TravisEz13
force-pushed
the
refactor-msi-generation
branch
from
878d4c9 to
25bd839
Compare
TravisEz13
force-pushed
the
refactor-msi-generation
branch
from
a342e60 to
866136b
Compare
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
Member
Author
|
cc @heaths |
adityapatwardhan
approved these changes
Jul 9, 2020
iSazonov
reviewed
Jul 10, 2020
heaths
approved these changes
Jul 10, 2020
| Write-Verbose "$resolvedWxsFiles" -Verbose | ||
|
|
||
| Write-Log "running candle..." | ||
| Start-NativeExecution -VerboseOutputOnError { & $wixPaths.wixCandleExePath $resolvedWxsFiles -out "$outDir\\" $extensionArgs -arch $ProductTargetArchitecture $buildArguments -v} |
Contributor
There was a problem hiding this comment.
Is the intent here to use msbuild eventually, or just to build MSIs and/or bundles separately?
TravisEz13
force-pushed
the
refactor-msi-generation
branch
from
6c7f999 to
27278b1
Compare
TravisEz13
added
the
CL-BuildPackaging
TravisEz13
changed the title
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactor MSI generation code to move candle and light to their own function
PR Context
Refactor msi code to make it easier to add a WiX EXE installer
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.