X Tutup
The Wayback Machine - https://web.archive.org/web/20210628142824/https://github.com/ionic-team/ionic-framework/pull/22241
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): improved lifecycle methods #22241

Merged
merged 11 commits into from Nov 10, 2020
Merged

Conversation

@michaeltintiuc
Copy link
Contributor

@michaeltintiuc michaeltintiuc commented Oct 2, 2020

  • Improve tooling by adding component options for lifecycle events, this allows for code completion and hinting.
  • Make fireLifecycle function's lifecycle argument stricter, limiting it to known lifecycle events
  • Reuse @ionic/core lifecycle exports
@liamdebeasi liamdebeasi changed the base branch from ionic-vue to master Oct 8, 2020
@michaeltintiuc michaeltintiuc force-pushed the michaeltintiuc:ionic-vue branch from b50af0f to 0638f14 Oct 14, 2020
@michaeltintiuc michaeltintiuc force-pushed the michaeltintiuc:ionic-vue branch from 0638f14 to daaddcc Oct 14, 2020
@liamdebeasi liamdebeasi changed the title [Vue] Lifecycle events tooling feat(vue): improved lifecycle methods Nov 5, 2020
@liamdebeasi liamdebeasi merged commit f5b0299 into ionic-team:master Nov 10, 2020
2 checks passed
2 checks passed
@github-actions
triage
Details
@circleci-checks
build Workflow: build
Details
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup