Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
chore: revert depreciate shelljs/make (#431) #458
Conversation
This reverts commit 5a31c7c.
zephraph
changed the title
nfischer
changed the title
|
I'll leave this to @ariporad to review. This commit seems to properly revert the feature, if that's something we want to do. Alternative approaches would be to display a different warning message instead. |
|
What different message would be displayed? Unless the deprecation is followed through with I wouldn't think there's a need to have a warning message. |
|
@zephraph: we've decided that this till will be unsupported going forward, so we're going to say something along those lines. Do you want to go ahead and add that, or should I? |
|
I don't think a message is necessary. Deprioritize it as a feature for support and shift the burden of maintenance onto the community. We could add a message in the documentation to explain as much. |
|
@zephraph's approach sounds good to me. LGTM |
|
SGTM |
This reverts commit 5a31c7c from #431.
This reverts the deprecation of the make command as noted in #340.