X Tutup
The Wayback Machine - https://web.archive.org/web/20250503015343/https://github.com/nodejs/node/issues/35519
Skip to content

Don't "exit" android-configure, which is meant to be "source"d #35519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fdgonthier opened this issue Oct 6, 2020 · 0 comments
Closed

Don't "exit" android-configure, which is meant to be "source"d #35519

fdgonthier opened this issue Oct 6, 2020 · 0 comments
Labels
android Issues and PRs related to the android platform. build Issues and PRs related to build files or the CI.

Comments

@fdgonthier
Copy link
Contributor

  • Version: 12.18.4
  • Platform: Linux

What steps will reproduce the bug?

Run android-configure, as prescribed, but without parameters

source ./android-configure

This will terminate my shell window.

What is the expected behavior?

Just show the error message and return.

Additional information

PR will soon follow.
@watilde watilde added android Issues and PRs related to the android platform. build Issues and PRs related to build files or the CI. labels Oct 16, 2020
@RaisinTen RaisinTen mentioned this issue Nov 15, 2020
Closed
4 tasks
@targos targos closed this as completed in 6c50d74 Dec 27, 2020
danielleadams pushed a commit that referenced this issue Jan 12, 2021
@fdgonthier @danielleadams
build: do not "exit" a script meant to be "source"d
ffaa8c1 
Running exit in a script meant to be sourced means the user shell will
exit, which prevents seeing the error message, and is generally very
annoying.
Fix the "android-configure" script to use "return" instead of "exit".

PR-URL: #35520
Fixes: #35519
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this issue May 1, 2021
@fdgonthier @targos
build: do not "exit" a script meant to be "source"d
38921b3 
Running exit in a script meant to be sourced means the user shell will
exit, which prevents seeing the error message, and is generally very
annoying.
Fix the "android-configure" script to use "return" instead of "exit".

PR-URL: #35520
Fixes: #35519
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Issues and PRs related to the android platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't 'exit' a script meant to be "source"d fdgonthier/node-1
2 participants
@fdgonthier @watilde
X Tutup