X Tutup
The Wayback Machine - https://web.archive.org/web/20201009015025/https://github.com/keon/algorithms/pull/691
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Largest Sum of Contiguous Subarray Algorithm. #691

Open
wants to merge 2 commits into
base: master
from

Conversation

@divakar-lakhera
Copy link

@divakar-lakhera divakar-lakhera commented Aug 19, 2020

Largest Sum of Contiguous Subarray with parameters for handling extreme negative values.

Largest Sum of Contiguous Subarray with parameters for handling extreme negative values.
@ericklarac
Copy link
Collaborator

@ericklarac ericklarac commented Aug 19, 2020

Is this kadane's algorithm?. Also, could you add some tests for the algorithm (Add them on the test folder on the corresponding file), and update the readme?

@divakar-lakhera
Copy link
Author

@divakar-lakhera divakar-lakhera commented Aug 20, 2020

Yes this is kadane's algo. I'll add some tests and update the readme.

Added Kadane's Algorithm.
Renames previous file.
Added Test Cases.
Editied Readme.
Copy link
Collaborator

@goswami-rahul goswami-rahul left a comment

Already implemented at dp/. Maybe add tests to tests/test_dp for the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup