X Tutup
The Wayback Machine - https://web.archive.org/web/20210124182739/https://github.com/creeperyang/koa-xml-body/pull/11
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser now adds `rawBody` to `ctx.request` #11

Merged
merged 4 commits into from Jul 6, 2020

Conversation

@nlang
Copy link
Contributor

@nlang nlang commented Jul 2, 2020

As the lib already uses raw-body to get the raw body from the request, it seem convenient to me to allow access to it. Other libs do this similar (e.g. koa-bodyparser), so I added that functionality.

lib/xml-parser.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@creeperyang
Copy link
Owner

@creeperyang creeperyang commented Jul 5, 2020

It all looks good. Please make eslint happy and go through all the tests.

@nlang
Copy link
Contributor Author

@nlang nlang commented Jul 5, 2020

It all looks good. Please make eslint happy and go through all the tests.

Tests already did pass. I fixed the things the linter complained about. Funny how things that are considered bad code in TS seem to be good enough for JS. Looking forward to getting a new version then :)

@creeperyang creeperyang merged commit f62e620 into creeperyang:master Jul 6, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nlang
Copy link
Contributor Author

@nlang nlang commented Jul 6, 2020

Thanks! Are you going to publish a new version to npm soon?

@creeperyang
Copy link
Owner

@creeperyang creeperyang commented Jul 7, 2020

v2.2.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup