X Tutup
The Wayback Machine - https://web.archive.org/web/20201006212549/https://github.com/TheAlgorithms/Python/pull/2885
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Euler Problem 80 #2885

Open
wants to merge 5 commits into
base: master
from

Conversation

@sandeepgupta007
Copy link

@sandeepgupta007 sandeepgupta007 commented Oct 5, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
sandeepgupta007 and others added 5 commits Oct 4, 2020
Rebasing
github-actions github-actions
@sandeepgupta007 sandeepgupta007 changed the title Sandeep dev 80 Project Euler Problem 80 Oct 5, 2020
@@ -0,0 +1,31 @@
"""
Euler Problem : 80

This comment has been minimized.

@dhruvmanila

dhruvmanila Oct 6, 2020
Member

  • Please remove the indentation, it's not needed for module level docstring
  • Simplify by removing @ symbol
answer += int(str(sqrt_number)[0])
sqrt_number = str(sqrt_number)[2:101]
answer += sum([int(x) for x in sqrt_number])
return answer

This comment has been minimized.

@dhruvmanila

dhruvmanila Oct 6, 2020
Member

I think your return statement is at wrong indentation level which is resulting in the wrong answer: https://travis-ci.com/github/TheAlgorithms/Python/jobs/395341755#L318-L321


def solution() -> int:
answer = 0
dot100 = decimal.Context(prec=105)

This comment has been minimized.

@dhruvmanila

dhruvmanila Oct 6, 2020
Member

Is it possible for a better variable name than dot100 ?

import decimal


def solution() -> int:

This comment has been minimized.

@dhruvmanila

dhruvmanila Oct 6, 2020
Member

Please include doctest and function docstring explaining in brief what this function does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup