Update android gradle plugin to 3.0.0-beta7 #4899
Merged
Conversation
This reverts commit e47c3e8.
zaki50
changed the title
zaki50
changed the title
zaki50
changed the title
|
3.0.0-beta4 has been released but it does not seem to allow specifying I've made an issue |
zaki50
changed the title
zaki50
changed the title
zaki50
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I've fixed all issues and we can merge this PR after the review. @realm/java
PR contains following changes.
This PR still has some issues.First execution of<- fixed by adding more task dependenciespublishToMavenLocaltask inrealm/realm-libraryproject aftercleanfails if gradle daemon is not used. Gradle doesn't executeassembletask in that case (build.gradlecontains explicit dependency toassembletask, no idea why not executed).Second time s always fine.
CMake build fails. This is caused by https://issuetracker.google.com/issues/65336086 and the status of the issue has become fixed. I think this build failure will be fixed in coming android gradle plugin.<- fixed in3.0.0-beta7