[android] fragment transactions#8791
[android] fragment transactions#8791NathanWalker merged 11 commits intoNativeScript:release/8.1.0from
Conversation
That way we dont “unload” and “load” fragments. This fixes black screens and slow transitions with opengl or cameras # Conflicts: # packages/core/ui/frame/fragment.transitions.android.ts # packages/core/ui/frame/frame-common.ts # packages/core/ui/frame/index.android.ts
This comment was marked as abuse.
This comment was marked as abuse.
|
They are not related and do not fix the same issue. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Merge whenever you want. Already using it in multiple prod apps from my fork ;) |
NathanWalker
force-pushed
the
master
branch
from
8753605 to
86395da
Compare
NathanWalker
force-pushed
the
master
branch
from
d4ced42 to
53488b5
Compare
NathanWalker
added
the
ready for test
|
@NathanWalker i guess you are looking at those right? again jut want to confirm i have multiple productions app running this. |
|
@rigor789 @NathanaelA @NathanWalker Thanks to that PR and a new commit Akylas@a4d7674 This is what we get today without that PR for Now this is what i get with Both the PR and the commit are needed to achieve this. I hope you are going to look at this. |
|
@farfromrefug we are going to get this into 8.1 - there's only 1 conflicted file related to automated test, could you just resolve that one conflict and then we can merge into a 8.1 prep branch we are working through. |
|
@NathanWalker great to hear. Will fix it on monday. Soon enough? |
|
Absolutely thank you! |
…ature/android_fragment_transition
…' on fwd navigation (#8791) Changes the behavior of android fragment transactions to use `add` instead of `replace` on forward navigation. BREAKING CHANGE: Changes the internal behavior of Android navigation: * while navigating forward, the page navigated from is not unloaded anymore * events order is changed in the sense that now `unloaded` happens after `navigatedFrom` instead of before There are multiple plus sides to this: * no more black views on navigation when using opengl (maps, ...) * navigation is faster, especially the navigation back! No longer need to recreate the page anymore. Navigation forward also gets faster as we no longer unload the previous page * navigatedFrom event happens faster * this the default behavior used by most of the android native apps
…' on fwd navigation (#8791) Changes the behavior of android fragment transactions to use `add` instead of `replace` on forward navigation. BREAKING CHANGE: Changes the internal behavior of Android navigation: * while navigating forward, the page navigated from is not unloaded anymore * events order is changed in the sense that now `unloaded` happens after `navigatedFrom` instead of before There are multiple plus sides to this: * no more black views on navigation when using opengl (maps, ...) * navigation is faster, especially the navigation back! No longer need to recreate the page anymore. Navigation forward also gets faster as we no longer unload the previous page * navigatedFrom event happens faster * this the default behavior used by most of the android native apps
|
I think it would be important to review this pr since it was reverted, the views with maps emit a flash with the navigation back This was discussed here: https://discord.com/channels/603595811204366337/751068755206864916/1030417807768297482 there are now more changes to make this work |
|
After all these years, there's still nothing new on this topic. Maybe it would be worth implementing this ready-made solution? |
5 participants
This PR changes the behavior of android fragment transactions to use
addinstead ofreplaceon forward navigationIt is a breaking change in the sense that it changes the internal behavior of Android navigation:
unloadedhappens afternavigatedFrominstead of beforeThere are multiple plus side o this:
navigatedFromevent happens fasterThis the default behavior used by most of the android native apps.