Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upchanges made to brackets in return statement for better understandment. #306
Conversation
|
I don't understand that
Em qui, 1 de out de 2020 00:46, sadique43 <notifications@github.com>
escreveu:
… Welcome to JavaScript community *Describe your change:*
- Add an algorithm?
- Fix a bug or typo in an existing algorithm?
- Documentation change?
*Checklist:*
- I have read CONTRIBUTING.md
<https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md>
.
- This pull request is all my own work -- I have not plagiarized.
- I know that pull requests will not be merged if they fail the
automated tests.
- This PR only changes one algorithm file. To ease review, please open
separate PRs for separate algorithms.
- All new JavaScript files are placed inside an existing directory.
- All filenames should use the UpperCamelCase (PascalCase) style.
There should be no spaces in filenames.
*Example:*UserProfile.js is allowed but userprofile.js,Userprofile.js,
user-Profile.js,userProfile.js are not
- All new algorithms have a URL in its comments that points to
Wikipedia or other similar explanation.
- If this pull request resolves one or more open issues then the
commit message contains Fixes: #{$ISSUE_NO}.
------------------------------
You can view, comment on, or merge this pull request online at:
#306
Commit Summary
- changes made to brackets in return statement for better
understandment.
File Changes
- *M* String/CheckPalindrome.js
<https://github.com/TheAlgorithms/Javascript/pull/306/files#diff-9e53af7e228db50fcbf4c531403ad7d1>
(6)
Patch Links:
- https://github.com/TheAlgorithms/Javascript/pull/306.patch
- https://github.com/TheAlgorithms/Javascript/pull/306.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#306>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARD2LZ53UIDAQSHJFIJPR2LSIP3TDANCNFSM4R7352EA>
.
|
|
Don't have error
Em qui, 1 de out de 2020 00:47, Vinicius Borges <
borgesvinicius0865@gmail.com> escreveu:
… I don't understand that
Em qui, 1 de out de 2020 00:46, sadique43 ***@***.***>
escreveu:
> Welcome to JavaScript community *Describe your change:*
>
> - Add an algorithm?
> - Fix a bug or typo in an existing algorithm?
> - Documentation change?
>
> *Checklist:*
>
> - I have read CONTRIBUTING.md
> <https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md>
> .
> - This pull request is all my own work -- I have not plagiarized.
> - I know that pull requests will not be merged if they fail the
> automated tests.
> - This PR only changes one algorithm file. To ease review, please
> open separate PRs for separate algorithms.
> - All new JavaScript files are placed inside an existing directory.
> - All filenames should use the UpperCamelCase (PascalCase) style.
> There should be no spaces in filenames.
> *Example:*UserProfile.js is allowed but userprofile.js,Userprofile.js,
> user-Profile.js,userProfile.js are not
> - All new algorithms have a URL in its comments that points to
> Wikipedia or other similar explanation.
> - If this pull request resolves one or more open issues then the
> commit message contains Fixes: #{$ISSUE_NO}.
>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #306
> Commit Summary
>
> - changes made to brackets in return statement for better
> understandment.
>
> File Changes
>
> - *M* String/CheckPalindrome.js
> <https://github.com/TheAlgorithms/Javascript/pull/306/files#diff-9e53af7e228db50fcbf4c531403ad7d1>
> (6)
>
> Patch Links:
>
> - https://github.com/TheAlgorithms/Javascript/pull/306.patch
> - https://github.com/TheAlgorithms/Javascript/pull/306.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#306>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARD2LZ53UIDAQSHJFIJPR2LSIP3TDANCNFSM4R7352EA>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.