X Tutup
The Wayback Machine - https://web.archive.org/web/20200914053034/https://github.com/github/octodns/pull/280
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DNS: Absorb CloudError exceptions #280

Open
wants to merge 2 commits into
base: master
from

Conversation

@koendc
Copy link

koendc commented Oct 25, 2018

CloudError exceptions are about not supported values. These exceptions
are now caught and a warning message is produced.
The apply phase will now continue with other changes instead of bailing
out with an exception.

Koen De Causmaecker
CloudError exceptions are about not supported values. These exceptions
are now caught and a warning message is produced.
The apply phase will now continue with other changes instead of bailing
out with an exception.
@koendc koendc force-pushed the koendc:azuredns-recover-from-errors branch to be6652f Oct 25, 2018
@ross
Copy link
Contributor

ross commented Jul 29, 2019

Sorry, I somehow missed this one coming through and only saw it when I was looking through the backlog.

I believe the CloudErrors being raised in this situation make sense. octoDNS generally throws errors if there are problems when things fail to apply. If those problems are due to bad data being configured in the zone file (that the provider doesn't accept) then we should look at handling that earlier on in the process, likely during planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup