X Tutup
The Wayback Machine - https://web.archive.org/web/20201001004118/https://github.com/TheAlgorithms/Javascript/pull/235
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Tweaks/Fixes #235

Merged
merged 1 commit into from Aug 1, 2020
Merged

Small Tweaks/Fixes #235

merged 1 commit into from Aug 1, 2020

Conversation

@ruppysuppy
Copy link
Contributor

@ruppysuppy ruppysuppy commented Jul 27, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • Fixes: #226 and #231
@itsvinayak

This comment has been minimized.

Copy link
Member

@itsvinayak itsvinayak commented on 52d70f9 Aug 1, 2020

@ruppysuppy nice work 👍

@itsvinayak itsvinayak merged commit df58a7e into TheAlgorithms:master Aug 1, 2020
2 checks passed
2 checks passed
build (14.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
X Tutup