X Tutup
The Wayback Machine - https://web.archive.org/web/20201001003959/https://github.com/TheAlgorithms/Javascript/pull/221
Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LFU Cache #221

Merged
merged 3 commits into from Jul 7, 2020
Merged

Added LFU Cache #221

merged 3 commits into from Jul 7, 2020

Conversation

@ruppysuppy
Copy link
Contributor

@ruppysuppy ruppysuppy commented Jul 4, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ruppysuppy
Added LFU Cache
Loading status checks…
feb0819
@itsvinayak
itsvinayak approved these changes Jul 6, 2020
View changes
@itsvinayak
itsvinayak requested changes Jul 6, 2020
View changes
Copy link
Member

@itsvinayak itsvinayak left a comment

please add some comment in the algorithm about,

  • explanation of algorithm
  • what each function do
@ruppysuppy
Added explaination for the algo
Loading status checks…
ea4ede1
@ruppysuppy
ruppysuppy reviewed Jul 7, 2020
View changes
Cache/LFUCache.js Outdated
@@ -55,6 +55,9 @@ class DoubleLinkedList {

class LFUCache {
// LFU Cache to store a given capacity of data
// The Double Linked List is used to store the order of deletion from the cache
// The rear.prev holds the most frequently used key and the head.next holds the lest used key

This comment has been minimized.

Sign in to view
@ruppysuppy

ruppysuppy Jul 7, 2020
Author Contributor

Typo, will fix it in a while
@ruppysuppy
Fixed Typo
Loading status checks…
89ea731
@ruppysuppy ruppysuppy requested a review from itsvinayak Jul 7, 2020
@itsvinayak
itsvinayak approved these changes Jul 7, 2020
View changes
@itsvinayak itsvinayak merged commit 7822e8a into TheAlgorithms:master Jul 7, 2020
2 checks passed
2 checks passed
build (14.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
Changes Required
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ruppysuppy @itsvinayak
You can’t perform that action at this time.
X Tutup