Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add crash.log to Packer.gitignore #3230
Merged
Conversation
If packer crashes, it write logs to the file "crash.log" in the current directory. This file should not be tracked in version control.
|
@sean-nixon thanks! |
tokuhira
added a commit
to tokuhira/gitignore
that referenced
this pull request
Dec 16, 2019
If packer crashes, it write logs to the file "crash.log" in the current directory. This file should not be tracked in version control.
EffingFancy
added a commit
to EffingFancy/gitignore
that referenced
this pull request
Feb 23, 2020
If packer crashes, it write logs to the file "crash.log" in the current directory. This file should not be tracked in version control.
r2pgl
added a commit
to r2pgl/gitignore
that referenced
this pull request
Mar 15, 2020
If packer crashes, it write logs to the file "crash.log" in the current directory. This file should not be tracked in version control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reasons for making this change:
If Packer crashes, it writes the panic output to the file
crash.login the current directory. This file should not be tracked in version control as it has the potential to contain sensitive information and is only useful for debugging. This behavior is the same as Terraform, which already includescrash.login its.gitignoretemplateLinks to documentation supporting these rule changes:
I was unable to find official documentation on this behavior, but it's pretty clear in panic output string in the source code here: https://github.com/hashicorp/packer/blob/master/panic.go