X Tutup
The Wayback Machine - https://web.archive.org/web/20200914222430/https://github.com/TheAlgorithms/Python/pull/2324
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data analysis #2324

Open
wants to merge 2 commits into
base: master
from
Open

Added data analysis #2324

wants to merge 2 commits into from

Conversation

@GohYauHong
Copy link

GohYauHong commented Aug 17, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
GohYauHong added 2 commits Aug 17, 2020
@GohYauHong
Create forest_fire.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
52617c8
@GohYauHong
Add forestfires data set via upload
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e5f2539
@TravisBuddy
Copy link

TravisBuddy commented Aug 17, 2020

Hey @GohYauHong,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f182e450-e089-11ea-a6dd-d374b9ca78b0
@cclauss
Copy link
Member

cclauss commented Aug 17, 2020

The GItHub Task List above works like this
https://docs.github.com/en/github/managing-your-work-on-github/about-task-lists
@cclauss
Copy link
Member

cclauss commented Aug 17, 2020

According to CONTRIBUTING.md, this is a how-to-use, not an algorithm. There is no algorithmic function, not doctests, no type hints, the solution is customized to one dataset and not a general solution. And the https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md
@abdoulayegk
Copy link

abdoulayegk commented Aug 17, 2020

@GohYauHong I encourage to use VS code and install the extension flake8 then you will be able to find all the error in your code.
first, your code contains a lot of whitespaces which is not accepted and the length of each line has to be a max of 88 char.
I think this will be help full to you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@GohYauHong @TravisBuddy @cclauss @abdoulayegk
You can’t perform that action at this time.
X Tutup