Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix false positive of AvoidAlias rule for implicit aliasing of Get- commands for the CommandType ExternalScript #1386
Conversation
…ommands for the CommandType ExternalScript
|
This looks great - do we need any additional validation, or is what we have sufficient? |
|
The manual end to end test (in vs code) is all I could as somehow this happens only when PSSA is hosted in the vs code extension where those command info cache entries got populated. |
bergmeister
merged commit ba7d01a
into
PowerShell:master
2 checks passed
2 checks passed
license/cla
All CLA requirements met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedJan 2, 2020
PR Summary
Fixes #1369
Unfortunately this issue could only be reproduced when PSSA is hosted within PSES where the root of the workspace becomes the working directory of the runspace pool, which causes
Get-Command ..\PathToScript.ps1to return a command type of ExternalScript, which then makes it into the command cache and causes the false positve.The fix is to search only for cmdlets/functions where the implicit
Get-aliasing applies.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.