Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix call to test a webhook method #915
Open
Conversation
|
Interesting. Are you calling this from a "GitHub app" or an "OAuth app". Do you know what version of GitHub Enterprise supports the new endpoint. Changing this could break things for those users. |
|
The result was the same for both GithubApp and oAuth App.
I don’t have GitHub enterprise so can’t comment on that.
…On Sun, 2 Aug 2020 at 22:35, Graham Campbell ***@***.***> wrote:
Interesting. Are you calling this from a "GitHub app" or an "OAuth app".
Do you know what version of GitHub Enterprise supports the new endpoint.
Changing this could break things for those users.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#915 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQRX75VNYKQ72J3OQVX4LR6XL3DANCNFSM4PSU4EIA>
.
|
|
I think we can safely apply this change, as in the github enterprise 2.18 docs the endpoint url is also like the note indicates {
"/repos/{owner}/{repo}/hooks/{hook_id}/tests":{
"post":{
"summary":"Test the push repository webhook",
"description":"This will trigger the hook with the latest push to the current repository if the hook is subscribed to `push` events. If the hook is not subscribed to `push` events, the server will respond with 204 but no test POST will be generated.\n\n**Note**: Previously `/repos/:owner/:repo/hooks/:hook_id/test`",
"tags":[
"repos"
],
"operationId":"repos/test-push-webhook",
"externalDocs":{
"description":"API method documentation",
"url":"https://developer.github.com/enterprise/2.18/v3/repos/hooks/#test-the-push-repository-webhook"
},
"parameters":[
{
"$ref":"#/components/parameters/owner"
},
{
"$ref":"#/components/parameters/repo"
},
{
"$ref":"#/components/parameters/hook-id"
}
],
"responses":{
"204":{
"description":"Empty response"
},
"404":{
"$ref":"#/components/responses/not_found"
}
},
"x-github":{
"githubCloudOnly":false,
"enabledForGitHubApps":true,
"previews":[
]
}
}
}
}https://github.com/github/rest-api-description/blob/main/descriptions/ghes-2.18/ghes-2.18.json What do you think @GrahamCampbell? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
morrislaptop commentedAug 2, 2020
•
edited
See renamed URL in the note at https://docs.github.com/en/rest/reference/repos#test-the-push-repository-webhook
Using old URL gives an error "Resource not accessible by integration"