Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded first version of source import #812
Conversation
|
Closing and reopening this PR to trigger the styleci build. |
|
I think there is something wrong with the styleci check. (This isn't the only PR where this seems to be hanging). |
|
The styleci integration is working again, there was an issue with linked user not having the required permission on github. (thanks @GrahamCampbell for the quick answer!) @sebastianberm Can you check the issues styleci has found? After those are fixed I will review this PR, thanks! |
| * | ||
| * return array | ||
| */ | ||
| public function start($params, $owner, $repoName) |
This comment has been minimized.
This comment has been minimized.
acrobat
Sep 29, 2019
Collaborator
I would move the $params parameter to the end of the function parameter list, to be in line with the rest of the code. This parameter can also be typehinted as array!
| * | ||
| * @link http://developer.github.com/v3/migrations | ||
| * | ||
| * @author Sebastian Berm <sebastian@sebsoft.nl> |
This comment has been minimized.
This comment has been minimized.
acrobat
Sep 29, 2019
Collaborator
Also add the @experimental annotation, to indicate this is a preview endpoint. See #806
|
@sebastianberm Can you also add some basic tests for the new endpoint? You can see an example here. |
|
This needs re-targetting to 2.x. |
sebastianberm commentedSep 25, 2019
This might not be 100% complete yet, but it should allow for source imports to take place.