X Tutup
The Wayback Machine - https://web.archive.org/web/20200917211535/https://github.com/nodejs/docker-node/pull/827
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Add windowsservercore with MSI installers #827

Open
wants to merge 1 commit into
base: master
from

Conversation

@nschonni
Copy link
Member

nschonni commented Jul 25, 2018

This doesn't replace the other Windows PRs like #720, just showing an alternate using the MSI installers.

EX:

  1. docker build .\8\windowsservercore\ -t nodejs:windowsservercore-8
  2. docker run --rm -it nodejs:windowsservercore-8 powershell
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

PS C:\> yarn --version
1.6.0
PS C:\> node --verson
C:\Program Files\nodejs\node.exe: bad option: --verson
PS C:\> node --version
v8.11.3
PS C:\> npm --version
5.6.0
PS C:\> whoami
user manager\containeradministrator

Pros:

  • The GPG part isn't needed
  • The MSIs setup perf counters and the Path automagially

Cons:

  • This method won't work for nanoserver. I've opened up nodejs/build#1413 to see if an APPX package can be built to support that.

/cc @LaurentGoderre @StefanScherer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.
X Tutup