X Tutup
The Wayback Machine - https://web.archive.org/web/20200914223552/https://github.com/TheAlgorithms/Python/pull/2376
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tox to handle virtual environment automatically #2376

Closed
wants to merge 5 commits into from
Closed

added tox to handle virtual environment automatically #2376

wants to merge 5 commits into from

Conversation

@meysam81
Copy link
Contributor

meysam81 commented Aug 31, 2020

Describe your change:

I have modified travis config a little bit to avoid unnecessary installing of libraries and instead added tox with a clean configuration that calculates coverage as well.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
meysam81 added 5 commits Aug 28, 2020
@meysam81
initial tox configuration
ec46265 
starting to migrate from virtualenv towards auto-generated env
@meysam81
tox: exclude tox directory from coverage report
5ba8d93
@meysam81
requirements: remove libraries that are installed directly in travis
455865a
@meysam81
travis: avoid installing requirements, and also run tox instead
a7ef9af
@meysam81
cill_cipher: modified expected doctest result to pass the test
Loading status checks…
265f7b6 
removed floating point

Fixes: #2128
@meysam81
Copy link
Contributor Author

meysam81 commented Aug 31, 2020

This PR is related to #2128
@meysam81
Copy link
Contributor Author

meysam81 commented Aug 31, 2020

I would also like to integrate coveralls or codecov to the project.
@cclauss
Copy link
Member

cclauss commented Aug 31, 2020

NO!
@cclauss cclauss closed this Aug 31, 2020
@cclauss
Copy link
Member

cclauss commented Aug 31, 2020 •
edited

Sorry but I hate tox as an extra layer of indirection and confusion that this project does not need.

The coverage report is already run by Travis on each pull request.
@meysam81 meysam81 deleted the meysam81:test/coverage branch Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@meysam81 @cclauss
You can’t perform that action at this time.
X Tutup