Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBE - Notifications #54
Conversation
| marked_read = BooleanField(default=False) | ||
|
|
||
| @property | ||
| def message_parameters_dict(self) -> dict: |
This comment has been minimized.
This comment has been minimized.
yammesicka
Apr 14, 2020
Member
Avoid verbosity when it isn't needed
@property
def params(self) -> Dict[str, Any]:
| cls, | ||
| for_user: User, | ||
| ) -> Iterable['Notification']: | ||
| return cls.select().join(User).filter( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yammesicka
Apr 14, 2020
Member
For the sake of consistency, because where is much more documented and because this is a thing that represent a query (in which you use WHERE clause)
| cls, | ||
| user: User, | ||
| notification_type: str, | ||
| message_parameters: dict, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| def get_notifications_for_user(for_user: models.User) -> typing.Sequence[dict]: | ||
| return tuple( | ||
| { | ||
| models.Notification.ID_FIELD_NAME: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gal432
Apr 14, 2020
Author
Member
Why? I think its cleaner, I need more models here - what is the point?
This comment has been minimized.
This comment has been minimized.
yammesicka
Apr 14, 2020
Member
It's just hurt the eyes to see many linebreaks and I think it too verbose, but as you wish :)
| instance.create_notification(for_user=for_user, **kwargs) | ||
|
|
||
|
|
||
| def get_notifications_for_user(for_user: models.User) -> typing.Sequence[dict]: |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

gal432 commentedApr 13, 2020
No description provided.