X Tutup
The Wayback Machine - https://web.archive.org/web/20200916191349/https://github.com/nodegit/nodegit/pull/971/commits
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make index methods async #971

Merged
merged 6 commits into from Apr 11, 2016
Merged

Make index methods async #971

merged 6 commits into from Apr 11, 2016

Commits on Apr 8, 2016

  1. Make index methods async

    Anytime the index reads/writes to the disk it should be non-blocking. Additionally this will give us thread safety protection since async methods are piped through the `LockManager`
    johnhaley81 committed Apr 8, 2016
  2. Fix "commit on head on empty repo with createCommitOnHead" test

    So this test was never valid ¯\_(ツ)_/¯
    
    You can't call `Index#addByPath` with an absolute path which was what was happening. Since the method was sync the result was considered the actual result of the call and not the error code so this error was never caught. Now that the function is async, that result is correctly interpretted and the test failed correctly.
    
    Changing this test to use the relative path fixes the test.
    johnhaley81 committed Apr 8, 2016
  3. Fix some formatting

    johnhaley81 committed Apr 8, 2016
  4. Fix staging tests

    Writing an index to disk is now async and no longer returns it's result code. Instead of checking for `0` we can just handle the error callback/rejected promise case.
    johnhaley81 committed Apr 8, 2016
  5. Sorted things in `descriptor.json` alphabetically

    johnhaley81 committed Apr 8, 2016
You can’t perform that action at this time.
X Tutup