Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose error code in Status.file #1468
Merged
Conversation
Due to a structural mistake in descriptor.json, Status.file does not expose git_status_file's error code in the rejected promise. The fix is the correct the JSON and also add a test to ensure that this case is covered should it happen again in the future. Signed-off-by: Remy Suen <remy.suen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rcjsuen commentedMar 21, 2018
The change I made for #1467 helped me discover an error in our wrapper for
git_status_file. It seems likeStatus.filedoes not actually expose the C function's error code when an error occurs. I've fixed the descriptor and also added a test to hopefully ensure that this won't happen again in the future.