X Tutup
The Wayback Machine - https://web.archive.org/web/20200916182340/https://github.com/nodegit/nodegit/pull/820
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable access to git_index_new and add test #820

Open
wants to merge 1 commit into
base: master
from

Conversation

@petemill
Copy link
Contributor

petemill commented Dec 9, 2015

Test is intermittently failing right now. The new index, which does not have a repository, and only 1 entry added to it, has an entry in a conflict state, but only sometimes when it is run.

When doing index.conflictGet only 1 of ours, theirs, base has the entry we added, the other 2 are null.

Not sure why - would appreciate any ideas.

@johnhaley81
Copy link
Collaborator

johnhaley81 commented Jan 21, 2016

Can you rebase this on top of master and enable thread safety to see if that fixes the issue please?

@petemill petemill force-pushed the petemill:index-create branch from b4f1245 to f76aaff Jan 22, 2016
@petemill
Copy link
Contributor Author

petemill commented Jan 22, 2016

@johnhaley81 rebased but unfortunately test still fails intermittently (fails more often than succeeds).

I ran the tests both with NODEGIT_TEST_THREADSAFETY=true and with NodeGit.enableThreadSafety() explicitly inside the test. Fails on both occasions with Index should not have conflicts.

@johnhaley81
Copy link
Collaborator

johnhaley81 commented Apr 9, 2016

@petemill Alright! Let's try this again. Can you rebase on top of #971 and see if that helps?

@srajko srajko force-pushed the nodegit:master branch 2 times, most recently from a78275a to 206d27d Apr 27, 2016
@implausible implausible force-pushed the nodegit:master branch from c345989 to c67b436 Aug 26, 2019
@implausible implausible force-pushed the nodegit:master branch from 2b7db46 to 69b010a Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup