X Tutup
The Wayback Machine - https://web.archive.org/web/20200916182511/https://github.com/nodegit/nodegit/pull/725
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let libssh2 configure generate its output #725

Open
wants to merge 1 commit into
base: master
from

Conversation

@saper
Copy link
Collaborator

saper commented Sep 17, 2015

No description provided.

@saper saper added the Build label Sep 17, 2015
@samkelleher
Copy link
Contributor

samkelleher commented Nov 6, 2015

@saper What does the spawn vs exec do here? Is a new process starting before a previous one has finished or something?

@maxkorp
Copy link
Collaborator

maxkorp commented Nov 9, 2015

It's allowing him to pipe stdio and stderr from the child process up to the main process.

@maxkorp

This comment has been minimized.

Copy link

maxkorp commented on a065d4a Nov 9, 2015

More reliable way to do this would be just to log stdout and stderr in the callback function on line 16

This comment has been minimized.

Copy link
Owner Author

saper replied Nov 10, 2015

At least this way I can see it live. in case of interruption it will be displayed as well.

This comment has been minimized.

Copy link

maxkorp replied Nov 10, 2015

True. I can't tell if the errors on this PR are from this change, or from travis because travis seems to enjoy spontaneous failures lately.

@maxkorp

This comment has been minimized.

Copy link

maxkorp commented on a065d4a Nov 9, 2015

More reliable way to do this would be just to log stdout and stderr in the callback function on line 16

This comment has been minimized.

Copy link
Owner Author

saper replied Nov 10, 2015

At least this way I can see it live. in case of interruption it will be displayed as well.

This comment has been minimized.

Copy link

maxkorp replied Nov 10, 2015

True. I can't tell if the errors on this PR are from this change, or from travis because travis seems to enjoy spontaneous failures lately.

@srajko srajko force-pushed the nodegit:master branch 2 times, most recently from a78275a to 206d27d Apr 27, 2016
@implausible implausible force-pushed the nodegit:master branch from c345989 to c67b436 Aug 26, 2019
@implausible implausible force-pushed the nodegit:master branch from 2b7db46 to 69b010a Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup