X Tutup
The Wayback Machine - https://web.archive.org/web/20200915171459/https://github.com/phpmyadmin/docker/pull/292
Skip to content

/ docker

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #292

Open
wants to merge 2 commits into
base: master
from
Open

Documentation fixes #292

wants to merge 2 commits into from

Conversation

@ibennetch
Copy link
Member

ibennetch commented May 18, 2020 •
edited

  • Grammar fixes
  • Document additional ENV variables
ibennetch added 2 commits May 18, 2020
@ibennetch
Grammar fixes
c5a8271 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch
Document more ENV variables that were added with #152
Loading status checks…
5d87e8f 
Related to 85198de and 93e2be7

Fixes #151

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch ibennetch changed the title Document additional ENV variables Documentation fixes May 18, 2020
@williamdes
williamdes reviewed May 18, 2020
View changes
README.md
server image for information how it is setup.
phpMyAdmin connects using your MySQL server credentials, please check the corresponding
database server image for information on what the default username and password are
or to modify these during installation.

This comment has been minimized.

Sign in to view
@williamdes

williamdes May 18, 2020

Member

I had to read it multiple times to understand the are or could you split this in two phrases please ?

This comment has been minimized.

Sign in to view
@ibennetch

ibennetch May 18, 2020

Author Member

Good suggestion, this is a bit too awkward.
@williamdes
williamdes reviewed May 18, 2020
View changes
README.md
@@ -130,6 +131,13 @@ Set the variable ``PMA_ABSOLUTE_URI`` to the fully-qualified path (``https://pma
* ``UPLOAD_LIMIT`` - if set, will override the default value for apache and php-fpm (default value is 2048 kb)
* ``PMA_CONFIG_BASE64`` - if set, will override the default config.inc.php with the base64 decoded contents of the variable
* ``PMA_USER_CONFIG_BASE64`` - if set, will override the default config.user.inc.php with the base64 decoded contents of the variable
* ``PMA_ABSOLUTE_URI`` - the full URL to phpMyAdmin. Sometimes needed when used in a reverse-proxy configuration. Don't set this unless needed
* ``PMA_CONTROLHOST`` - when set, this points to an alternate database host used for storing the phpMyAdmin Configuration Storage database

This comment has been minimized.

Sign in to view
@williamdes

williamdes May 18, 2020

Member
Suggested change
* ``PMA_CONTROLHOST`` - when set, this points to an alternate database host used for storing the phpMyAdmin Configuration Storage database
* ``PMA_CONTROLHOST`` - when set, this points to an alternate database host used for storing the [phpMyAdmin Configuration Storage database](https://docs.phpmyadmin.net/en/latest/setup.html#phpmyadmin-configuration-storage)

Maybe a link to our docs could be a nice to have ?

This comment has been minimized.

Sign in to view
@ibennetch

ibennetch May 18, 2020

Author Member

Excellent suggestion. I forgot this was Markdown for a moment and that linking is easy. I'll do this.
@williamdes
williamdes approved these changes May 18, 2020
View changes
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the wontfix label Jul 18, 2020
@williamdes williamdes removed the wontfix label Jul 18, 2020
@williamdes
Copy link
Member

williamdes commented Jul 31, 2020

🏓 @ibennetch do you want to finish this one before the next 5.0.x release ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ibennetch @williamdes
You can’t perform that action at this time.
X Tutup