X Tutup
The Wayback Machine - https://web.archive.org/web/20200912031046/https://github.com/angular/angular/issues/38739
Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format of ISO week-numbering year #38739

Open
wenqi73 opened this issue Sep 8, 2020 · 5 comments
Open

Add format of ISO week-numbering year #38739

wenqi73 opened this issue Sep 8, 2020 · 5 comments
Labels
comp: common good first issue type: feature
Milestone
Backlog

Comments

@wenqi73
Copy link

@wenqi73 wenqi73 commented Sep 8, 2020

🚀 feature request

Relevant Package

This feature request is for @angular/common

Description

formatDate(new Date(2018, 11, 31), 'yyyy-ww', 'en-US')
// 2018-01

Week is right but year is wrong.

Describe the solution you'd like

Add an ISO week-numbering year like rrrr.

formatDate(new Date(2018, 11, 31), 'rrrr-ww', 'en-US')
// 2019-01

Here is the reference of date-fns.

Describe alternatives you've considered
@wenqi73 wenqi73 changed the title Add ISO week-numbering year Add format of ISO week-numbering year Sep 8, 2020
@wenqi73 wenqi73 mentioned this issue Sep 8, 2020
Open
@ngbot ngbot bot added this to the Backlog milestone Sep 8, 2020
@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Sep 8, 2020

Normally I am cautious about adding new functionality but I think that this case could be an exception. Since we are already doing the calculations for the week numbering, it is probably not too much more to compute the "week year".

This might be a good first time PR for someone... 🤔
@prashant-tholia
Copy link

@prashant-tholia prashant-tholia commented Sep 10, 2020

Hi, I'd like to work on this issue.
@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Sep 10, 2020

@prashant-tholia - great! Please make sure you have read https://github.com/angular/angular/blob/master/CONTRIBUTING.md.
The PR will need to include unit tests and documentation before it can be merged.

Let me know if you need help getting started.
@prashant-tholia
Copy link

@prashant-tholia prashant-tholia commented Sep 10, 2020

Thanks @petebacondarwin! I'll make sure to fulfill all mentioned guidelines and requirements.
@irzakamran
Copy link

@irzakamran irzakamran commented Sep 10, 2020

Hello, can I also be work on this issue with @prashant-tholia since this is a good first issue and I am an open source beginner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: common good first issue type: feature
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@petebacondarwin @sonukapoor @wenqi73 @irzakamran @prashant-tholia
You can’t perform that action at this time.
X Tutup