X Tutup
The Wayback Machine - https://web.archive.org/web/20260215132945/https://github.com/RustPython/RustPython/pull/2146
Skip to content

Add ftplib + test_ftplib#2146

Merged
youknowone merged 8 commits intomasterfrom
coolreader18/test_ftplib
Jan 12, 2021
Merged

Add ftplib + test_ftplib#2146
youknowone merged 8 commits intomasterfrom
coolreader18/test_ftplib

Conversation

@coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Aug 25, 2020

I tried to get ssl working, but it's just such a pain. I got it to an sort of useful error message after updating socket.py, but I was sorta burnt out by then, especially after I git reset --hard half my work accidentally. I just want this out of my face at this point 😅

@coolreader18 coolreader18 marked this pull request as draft August 25, 2020 01:46
@coolreader18
Copy link
Member Author

Actually, I think I'll keep this a draft til rust-lang/socket2#97 is resolved/a new version is pushed

@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch 2 times, most recently from d3d9bb1 to caea922 Compare August 25, 2020 23:58
@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch from caea922 to 61c3373 Compare September 9, 2020 23:43
@coolreader18
Copy link
Member Author

Okay, this is the same socket error as #2179, so at least all the issues on the ftplib end are fixed

@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch from 61c3373 to 37af8c2 Compare September 10, 2020 00:07
youknowone added a commit that referenced this pull request Sep 11, 2020
@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch from 37af8c2 to 09fa6ee Compare September 12, 2020 00:25
@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch 2 times, most recently from 68f1806 to 9d19159 Compare September 20, 2020 23:04
@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch 2 times, most recently from d21ef23 to d4ccd38 Compare January 11, 2021 18:45
@coolreader18 coolreader18 marked this pull request as ready for review January 11, 2021 18:58
@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch from c05376e to 6fd7f58 Compare January 11, 2021 20:41
@coolreader18 coolreader18 force-pushed the coolreader18/test_ftplib branch from 6fd7f58 to 07cad58 Compare January 11, 2021 23:32
@youknowone youknowone merged commit 39c18fe into master Jan 12, 2021
@youknowone youknowone deleted the coolreader18/test_ftplib branch January 12, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup