X Tutup
The Wayback Machine - https://web.archive.org/web/20201103184259/https://github.com/TheAlgorithms/Java/pull/1445
Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MinimumSumPartition.java #1445

Merged
merged 11 commits into from Sep 6, 2020
Merged

Update MinimumSumPartition.java #1445

merged 11 commits into from Sep 6, 2020

Conversation

@tribbleofjim
Copy link
Contributor

@tribbleofjim tribbleofjim commented Sep 6, 2020 •
edited

fix code issue

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@tribbleofjim
Update MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e7193aa 
fix code issue
@tribbleofjim
Copy link
Contributor Author

@tribbleofjim tribbleofjim commented Sep 6, 2020

It's my first time to commit a file. I want to explain why I did that.
In the origin code, if we use array[1, 2, 3, 9] to test it, we will see that the code return an answer 5 instead of the correct answer 3.(subset{1, 2, 3} and subset{9})
so I fixed it.
@shellhub
shellhub requested changes Sep 6, 2020
View changes
Copy link
Member

@shellhub shellhub left a comment

Please use java style instead of c-style. And format code with your IDE (e.g. IntelliJ IDEA) . Thanks :)
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
@shellhub
shellhub requested changes Sep 6, 2020
View changes
DynamicProgramming/MinimumSumPartition.java Outdated Show resolved Hide resolved
tribbleofjim and others added 10 commits Sep 6, 2020
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
928f212 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
880240c 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9672ffc 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e27175b 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6fdd9c9 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e8a4628 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ad3bb81 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6951230 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
86d6e93 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim @shellhub
Update DynamicProgramming/MinimumSumPartition.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3e727e3 
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@tribbleofjim
tribbleofjim reviewed Sep 6, 2020
View changes
Copy link
Contributor Author

@tribbleofjim tribbleofjim left a comment

I have resolved these changes. Thanks a lot for the advisor. :)
@shellhub
shellhub approved these changes Sep 6, 2020
View changes
Copy link
Member

@shellhub shellhub left a comment

Thanks for your contribution.
@shellhub shellhub merged commit f2f42f3 into TheAlgorithms:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellhub shellhub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tribbleofjim @shellhub
You can’t perform that action at this time.
X Tutup