X Tutup

COLLECTED BY

Organization: Archive Team

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

History is littered with hundreds of conflicts over the future of a community, group, location or business that were "resolved" when one of the parties stepped ahead and destroyed what was there. With the original point of contention destroyed, the debates would fall to the wayside. Archive Team believes that by duplicated condemned data, the conversation and debate can continue, as well as the richness and insight gained by keeping the materials. Our projects have ranged in size from a single volunteer downloading the data to a small-but-critical site, to over 100 volunteers stepping forward to acquire terabytes of user-created data to save for future generations.

The main site for Archive Team is at archiveteam.org and contains up to the date information on various projects, manifestos, plans and walkthroughs.

This collection contains the output of many Archive Team projects, both ongoing and completed. Thanks to the generous providing of disk space by the Internet Archive, multi-terabyte datasets can be made available, as well as in use by the Wayback Machine, providing a path back to lost websites and work.

Our collection has grown to the point of having sub-collections for the type of data we acquire. If you are seeking to browse the contents of these collections, the Wayback Machine is the best first stop. Otherwise, you are free to dig into the stacks to see what you may find.

The Archive Team Panic Downloads are full pulldowns of currently extant websites, meant to serve as emergency backups for needed sites that are in danger of closing, or which will be missed dearly if suddenly lost due to hard drive crashes or server failures.

Collection: Archive Team: The Github Hitrub

This collection is a set of Github repository archives from two major sets: A panic grab upon the acquisition by Microsoft, and a larger, ongoing set of Pretty Much Everything.

TIMESTAMPS

The Wayback Machine - https://web.archive.org/web/20200905014531/https://github.com/bpython/bpython/pull/839

bpython / bpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width awareness to fix wrapping of strings with full width chars #839

Open

rybarczykj wants to merge 1 commit into bpython:master from rybarczykj:wrapping

Contributor

rybarczykj commented Aug 5, 2020

This is a redux of #731 which was put on hold until a need for width awareness was found. I'd say this is a decent justification for bringing it back

Wrapping strings with fullwidth chars
Here's the same string being typed before and after width awareness:

New method to fix cursor position:
When we put a 2-column character at the end of the line where there's only 1 column of room, curtsies adds a padding character (space) so we can kick it down to the line below. Therefore, in order to get the right cursor position, I had to add a method that determines how many padding chars there are (number_of_padding_chars_on_current_cursor_line).

Note on this method: Right now, to determine the amount of padding, it calls display_linize, doubling the amount of times we call that function. It's definitely possible to keep track of this as a variable in the repl class instead, or to do some changes other to ensure less redundant work is done. Feedback appreciated.

Runtime
One of the barriers stopping us from implementing this before was runtime . I did not find any noticeable difference when pasting, printing, or moving my cursor around large strings.

sebastinas reviewed

bpython/curtsiesfrontend/repl.py Outdated Show resolved Hide resolved

rybarczykj marked this pull request as ready for review

Contributor

sebastinas commented Aug 14, 2020

Could you please rebase this PR?

rybarczykj force-pushed the rybarczykj:wrapping branch from 83d87fd to a7bb458

Contributor Author

rybarczykj commented Aug 17, 2020 •

edited

Just noticed a bug with this; maybe don't accept yet.

width_aware_splitlines throws an error and bpython crashes when the user printes format strings by importing curtsies. This is because wcswidth can't parse strings that look like this '\x1b[36m\x1b[42ma\x1b[49m\x1b[39m'. Maybe we should just try to use the old method if an error like this is thrown.

rybarczykj force-pushed the rybarczykj:wrapping branch from a7bb458 to 90cdd1d

Contributor Author

rybarczykj commented Aug 18, 2020

That bug I mentioned ^^ is fixed now, as of that last push. Now, if wcswidth throws an error, we catch it and use the old display_linize.

I also added some relevant tests.


        Integrate width awareness

9da6783

- update display_linize to use curtsies 3.0 width functionality
- correct cursor positioning on wrapped fullwidth chars by adding new method
- add test coverage

rybarczykj force-pushed the rybarczykj:wrapping branch from 90cdd1d to 9da6783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.

X Tutup