X Tutup

The Wayback Machine - https://web.archive.org/web/20200627234459/https://github.com/angular/angular/pull/36940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand scope of formatting to enforce formatting on more files #36940

Closed

josephperrott wants to merge 4 commits into angular:master from josephperrott:expand-formatting

+34,731 −37,745

Member

josephperrott commented May 5, 2020

See individual commits.

All js/ts changes in this change are the result of clang-format enforcing format on the code.

josephperrott added comp: build & ci comp: i18n PR target: master & patch labels

ngbot bot modified the milestone: needsTriage

googlebot added the cla: yes label

josephperrott marked this pull request as ready for review

pullapprove bot requested review from filipesilva, kara and petebacondarwin

josephperrott force-pushed the josephperrott:expand-formatting branch from d3152b0 to f10ab5a

josephperrott force-pushed the josephperrott:expand-formatting branch from f10ab5a to 691e8c2

petebacondarwin approved these changes

Member

petebacondarwin left a comment

Reviewed-for: fw-i18n

The commit message scope should be common not localize.

petebacondarwin added the PR action: cleanup label

josephperrott added 3 commits


        build: increase scope of files with enforced formatting

5f5e153

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.


        style(dev-infra): enforce format on newly included files

d9fd528

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.


        style(common): enforce format on newly included files

2b9624f

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

josephperrott requested review from devversion and IgorMinar and removed request for kara and filipesilva

pullapprove bot requested a review from atscott

josephperrott force-pushed the josephperrott:expand-formatting branch from 691e8c2 to 2b9624f


        fixup! style(dev-infra): enforce format on newly included files

c66c62e

josephperrott removed the request for review from IgorMinar

devversion approved these changes

Member

devversion left a comment

LGTM. @josephperrott I'm assuming we can rely on the extract-cldr script outputting properly formatted files? I see it runs clang-format, so whenever we should re-generate the data, there should be no formatting changes?

Member Author

josephperrott commented Jun 10, 2020

@devversion Correct, when we recreate the CLDR data it will be created correctly as we run the same formatter over it as we do for our enforcement.

josephperrott added PR action: merge and removed PR action: cleanup labels

atscott approved these changes

Contributor

atscott left a comment •

edited

We should give a heads-up ping to everyone before merging this.

Review-for: fw-core

Member Author

josephperrott commented Jun 12, 2020

@atscott Happy to announce, though it looks like this will not effect much outstanding work:

$ yarn -s ng-dev pr discover-new-conflicts 36940
Requesting pending PRs from Github
Retrieved 615 total pending PRs
Checking 147 PRs for conflicts after a merge of #36940
[========================================] ETA: 0s | 147/147

Result:
1 PR(s) which conflict(s) after #36940 merges:
    - 37263: Added the method addValidators and addAsyncValidators

Contributor

atscott commented Jun 12, 2020

@atscott Happy to announce, though it looks like this will not effect much outstanding work:
$ yarn -s ng-dev pr discover-new-conflicts 36940

Oh, that's cool. Didn't know we had that! One thing I just thought of: could you update the required base sha so that we ensure PRs are formatted correctly?

Member Author

josephperrott commented Jun 12, 2020

@atscott will do in a follow up PR once we have the SHAs available from this PR merging.

josephperrott added comp: core comp: dev-infra cla: yes and removed cla: yes labels

mhevery added a commit that referenced this pull request


        build: increase scope of files with enforced formatting (#36940)

45a8f34

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close #36940

mhevery added a commit that referenced this pull request


        style(dev-infra): enforce format on newly included files (#36940)

fcd934c

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close #36940

mhevery added a commit that referenced this pull request


        style(common): enforce format on newly included files (#36940)

dbff6f7

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close #36940

mhevery closed this in

34e4098

mhevery added a commit that referenced this pull request


        style(dev-infra): enforce format on newly included files (#36940)

d3b5e56

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close #36940

mhevery added a commit that referenced this pull request


        style(common): enforce format on newly included files (#36940)

1bc807c

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close #36940

ngwattcos added a commit to ngwattcos/angular that referenced this pull request


        build: increase scope of files with enforced formatting (angular#36940)

a263266

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close angular#36940

ngwattcos added a commit to ngwattcos/angular that referenced this pull request


        style(dev-infra): enforce format on newly included files (angular#36940)

9d57848

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close angular#36940

ngwattcos added a commit to ngwattcos/angular that referenced this pull request


        style(common): enforce format on newly included files (angular#36940)

5a9eea7

Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close angular#36940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.

X Tutup