X Tutup

The Wayback Machine - https://web.archive.org/web/20210420233522/https://github.com/code-dot-org/code-dot-org/pull/23613

code-dot-org / code-dot-org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix violations of and reenable rubocop Style/RedundantBegin. #23613

Merged

balderdash merged 2 commits into code-dot-org:staging from asherkach:rubocop-style-redundant-begin

Jul 13, 2018

Contributor

asherkach commented Jul 10, 2018

No description provided.

Contributor Author

asherkach commented Jul 10, 2018

@epeach, mind kicking off a CircleCI run? The auto-correct botched it badly enough I want to spend a few minutes sanity checking this PR, no need to review it yet.

Contributor Author

asherkach commented Jul 11, 2018

Ping @epeach (former DOTD) or @balderdash (current DOTD).

balderdash reviewed

large_files.sh Outdated

  
      @@ -0,0 +1,33 @@
    
        #!/bin/bash

balderdash Jul 11, 2018
Contributor

I'm guessing this file isn't meant to be here.

asherkach Jul 12, 2018
Author Contributor

No idea how it ended up there. Your guess is correct, removed.

asherkach added 2 commits


          Fix violations of rubocop Style/RedundantBegin.

d5cebfa


          Reenable rubocop Style/RedundantBegin.

asherkach force-pushed the asherkach:rubocop-style-redundant-begin branch from 65eef04 to 5997347

balderdash approved these changes

balderdash merged commit 402447a into code-dot-org:staging

2 checks passed

2 checks passed

DTS The staging branch is open.

ci/circleci Your tests passed on CircleCI!

Details

asherkach deleted the asherkach:rubocop-style-redundant-begin branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

X Tutup