keep the var in front of variable names

do you mean revert commit 4 (hoist all vars to top of function-scope)? i can do that. just making sure that is the meaning.

do you mean revert commit 4 (hoist all vars to top of function-scope)? i can do that. just making sure that is the meaning.

yes

added 2 more follow-on commits:

commit 6

- revert previous commit and relax eslint-rule "vars-on-top": "on" to "vars-on-top": "off"

commit 7

- remove from /test/ invalid-code containing free-variable assert

i still want to keep relaxed the eslint-rule:

        // reason - test-cases use nameless, anonymous-functions for callbacks
        "func-names": "off",

reason is if you look at /test/test_worker.js, it has 14 anonymous-function callbacks, and is PITA to maintain unique func-name for each of them :`(

pinging about status of this pull-request? have more pull-requests in pipeline, but would like a style-guide inplace first if possible.

There is a lot of what looks like unchecked auto-formatting. Can you proofread the whole code you generated, and re-request a review once it's clean ?

K, I'll try to get around to it this weekend.

want to re-introduce default airbnb eslint-rule "vars-on-top": "on" to enforce program-correctness.

according to official es5 language-spec @ https://www.ecma-international.org/ecma-262/5.1/#sec-12.1:

A variable statement declares variables that are created as defined in 10.5. Variables are initialised to undefined when created. A variable with an Initialiser is assigned the value of its AssignmentExpression when the VariableStatement is executed, not when the variable is created.

so this code in src/api.js:

function extract_blob(ptr) {
    ...
    for (var j = 0; j < size; j += 1) {
        blob_arg[j] = HEAP8[blob_ptr + j];
    }
    return blob_arg;
}

is internally transformed by spec-compliant engines to this:

 function extract_blob(ptr) {
+    var j = undefined; // Variables are initialised to undefined when created as defined in 10.5
     ...
-    for (var j = 0; j < size; j += 1) {
+    for (j = 0; j < size; j += 1) { // Initialiser is assigned when executed
         blob_arg[j] = HEAP8[blob_ptr + j];
     }
     return blob_arg;
 }

the eslint-rule "vars-on-top": "on" forces users to explicitly/correctly do what js-engines already do internally.

it also makes proof-reading /test/ directory easier, since i (and future test-writers) no longer have to keep track of where the first variable assignment took place (when there are multiple assignments).

I know how variable declarations in javascript work, thank you 😃
This can be discussed, but I find the code with variable declarations on top to be much more difficult to read.

finished proofreading/linting the 2 most problematic test-files:

• /test/test_functions.js
• /test/test_workers.js

with proposed eslint-flag changes:

+        // reason - test-cases use nameless, anonymous-functions for callbacks
+        "func-names": "off",
+        // reason - test-cases use lazy/conditional require
+        "global-require": "off",
+        // reason - test-cases use console.log and console.error
+        "no-console": ["error", { allow: ["error", "log"] }],
-        "vars-on-top": "off"

lets just focus this pull-request on above 2 test-files.

once merged, a separate pull-request to lint remaining test files should be trivial.

closing this due to inactivity, but may re-open in future.