X Tutup
The Wayback Machine - https://web.archive.org/web/20201023142401/https://github.com/nodejs/node/issues/33631
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing single quotes in api/tls.md for v10.x #33631

Open
mscdex opened this issue May 29, 2020 · 5 comments
Open

doc: missing single quotes in api/tls.md for v10.x #33631

mscdex opened this issue May 29, 2020 · 5 comments
Labels
doc good first issue tls v10.x

Comments

@mscdex
Copy link
Contributor

@mscdex mscdex commented May 29, 2020

  • Version: v10.x
  • Platform: n/a
  • Subsystem: doc, tls

The minVersion and maxVersion descriptions in the tls docs are missing single quotes before TLSv1.2. The docs for newer branches do not have this issue.
@sparsh-99
Copy link

@sparsh-99 sparsh-99 commented May 29, 2020

Assign it to me... I am already working on this!!!
@sparsh-99
Copy link

@sparsh-99 sparsh-99 commented May 29, 2020

@mscdex Where I can find tls.md file of v10.x?
@sam-github
Copy link
Contributor

@sam-github sam-github commented May 29, 2020

https://github.com/nodejs/node/blob/v10.x-staging/doc/api/tls.md
@sparsh-99
Copy link

@sparsh-99 sparsh-99 commented May 29, 2020

#33641 Successfully opened PL to this issue
Thank You @mscdex @sam-github
This is my first PL towards the Open Source Projects
@sparsh-99 sparsh-99 mentioned this issue Jun 15, 2020
Closed
2 of 2 tasks complete
@dnswd
Copy link

@dnswd dnswd commented Aug 4, 2020

This issue is solved on 00f04e3. Consider closing this issue @mscdex .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc good first issue tls v10.x
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@sam-github @mscdex @dnswd @sparsh-99
You can’t perform that action at this time.
X Tutup