Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport markdown multi-line highlight for constructs with inline-content #847
Comments
|
Feel free to make a PR. You can get it done in 2h. |
|
@tinmarino, is this just syntax highlighting for these or is there extra logic to do? If it's just syntax highlighting, then we could pop in a |
|
Speaking of this multi-line highlight not supported, there is a similar issue when using - [x] hello
world(multiline is actually kind of supported, because when under "world", I can open another issue if needed. |
According to the issue creator, it is just syntax highliting, for me too. But this may break the html conversion that is done line by line.
Yes it would be better: Small issues are easier to close. So it divides better the dev workflow. Please:
|
|
@ubitux before opening a new issue, check if that answer solves it (found searching
|
|
@chipsenkbeil yes it would be better as a region as tim pope is doing in the default markdown syntax : it is much cleaerer |
…iki#847, vimwiki#640) - Less code, Easyer to maintain, to add a markup language - Faster to load, and to highlight - Support multiline tags: vimwiki#847 - Support nested tags - Support intraword tags: this<b>bold</b>type vimwiki#640
…iki#847, vimwiki#640) - Less code, Easyer to maintain, to add a markup language - Faster to load, and to highlight - Support multiline tags: vimwiki#847 - Support nested tags - Support intraword tags: this<b>bold</b>type vimwiki#640
|
Ok this one is not finished: |
…iki#847, vimwiki#640) - Less code, Easyer to maintain, to add a markup language - Faster to load, and to highlight - Support multiline tags: vimwiki#847 - Support nested tags - Support intraword tags: this<b>bold</b>type vimwiki#640
According to latest CommonMark spec as of
0.29(https://spec.commonmark.org/0.29/#example-635), the following example should be highlighted:With Vimwiki, the
concealis not effective here, which hints me that the highlight is not set (would be nice to have a different color for this markup by default).Similarly, the following doesn't work (which is the one I use since it displays in a different color, even though the semantic is most of the time not correct):
Note that the spec says "Line breaks do not occur inside code spans", but this is only referring to the multi-line rendering: if you look at the output, it will still consider the whole thing as inline-code (ignoring the line break).
I use the
gqcommand a lot, and thus the markup regularly breaks because of auto inserted line-breaks within highlighted sentences / word-groups.Note: this issue is likely a good candidate for #664.
:VimwikiShowVersion:The issue is also reproducible with
master.