Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add supoort for Tls 1.3 in Web cmdlets #13409
Conversation
iSazonov
added
the
CL-General
iSazonov
requested review from
vexx32,
daxian-dbw,
TravisEz13,
adityapatwardhan,
SteveL-MSFT and
markekraus
|
Would be great if we can add a test. |
|
I added tests. |
|
After investigations of new test failures I found that .Net delegates the TLS support to underlying OS. The TLS 1.3 support on all OS-s is limited. Invoke-WebRequest -SslProtocol tls13 https://tls13.akamai.io/
Invoke-WebRequest: Authentication failed because the remote party sent a TLS alert: 'HandshakeFailure'.MacOS haven't the support at all. Linux - depends on used OpenSSL lib. @SteveL-MSFT We need a conclusion:
|
| @{ Test = @{SslProtocol = 'Tls11, Tls12'; ActualProtocol = 'Tls11'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11'; ActualProtocol = 'Tls11'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11, Tls12'; ActualProtocol = 'Tls'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11, Tls13'; ActualProtocol = 'Tls'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11'; ActualProtocol = 'Tls'}; Pending = $false } | ||
| # Skipping intermediary protocols is not supported on all platforms | ||
| @{ Test = @{SslProtocol = 'Tls, Tls12'; ActualProtocol = 'Tls'}; Pending = -not $IsWindows } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls12'; ActualProtocol = 'Tls12'}; Pending = -not $IsWindows } | ||
| ) | ||
|
|
||
| $testCases2 = @( |
There was a problem hiding this comment.
Can you add a comment that these are failing test cases
| @{ Test = @{SslProtocol = 'Tls11, Tls12'; ActualProtocol = 'Tls11'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11'; ActualProtocol = 'Tls11'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11, Tls12'; ActualProtocol = 'Tls'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11, Tls13'; ActualProtocol = 'Tls'}; Pending = $false } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls11'; ActualProtocol = 'Tls'}; Pending = $false } | ||
| # Skipping intermediary protocols is not supported on all platforms | ||
| @{ Test = @{SslProtocol = 'Tls, Tls12'; ActualProtocol = 'Tls'}; Pending = -not $IsWindows } | ||
| @{ Test = @{SslProtocol = 'Tls, Tls12'; ActualProtocol = 'Tls12'}; Pending = -not $IsWindows } | ||
| ) | ||
|
|
||
| $testCases2 = @( |
Put the tests at pending and file an issue. Note the issue in a comment in the test code. Best if you pend the test cases like this: |
|
@TravisEz13 Tracking issue is created and the comment is added to the tests. (I can not use |
|
Rebased to pass CIs. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
@iSazonov looks like this may need another rebase. Once CI passes, I'll merge |
rjmholt
added
the
Waiting on Author
ghost
removed
the
Waiting on Author
rjmholt
added
the
Waiting on Author
|
CI still failing |
ghost
removed
the
Waiting on Author
|
🎉 Handy links: |
ghost
mentioned this pull request
PR Summary
Fix #13398
Add new element in WebSslProtocol enum.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.