X Tutup
The Wayback Machine - https://web.archive.org/web/20201125092030/https://github.com/SheetJS/sheetjs/pull/2029
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlsx-cli refactor #2029

Open
wants to merge 4 commits into
base: master
from
Open

xlsx-cli refactor #2029

wants to merge 4 commits into from

Conversation

@garrettluu
Copy link
Contributor

@garrettluu garrettluu commented Jun 27, 2020

Closes #1922

Refactored the CLI into packages/xlsx-cli and published the NPM package here.
With this refactor, we have completely commander and exit-on-epipe as dependencies in the main library and the submodules.

For convenience, here are the PRs for the CLI refactors of the submodules in one place:

To run the cli, install it with npm i -g xlsx-cli, then run npx xlsx-cli.

@garrettluu garrettluu requested review from SheetJSDev and srijonsaha Jun 27, 2020
Copy link
Contributor

@srijonsaha srijonsaha left a comment

There's some conflicts that need to be resolved. Otherwise looks good to me.

"fs": "^0.0.1-security",
"xlsx": "^0.16.2"
},
"devDependencies": {},

This comment has been minimized.

@srijonsaha

srijonsaha Jun 29, 2020
Contributor

this line could be removed (minor thing)

@stof
Copy link

@stof stof commented Jul 16, 2020

The xlsx-cli package.json should have the repository config, so that npmjs.com can link to the source repository.

@stof
Copy link

@stof stof commented Jul 16, 2020

@garrettluu the codepapage package also needs such a refactoring

@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 0786b99 to 3b589f0 Aug 12, 2020
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 4254ed4 to eec93b0 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.
X Tutup