Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: Use the shared font family for the shell box #808
+1
−1
Conversation
|
/preview |
github-actions
bot
commented
Aug 10, 2020
|
Please find a preview at: https://staging.nodejs.dev/808/ |
|
Thanks for the contribution |
designMoreWeb left a comment
|
Looks good to me |
|
This can presumably be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JohnPhamous commentedAug 10, 2020
Description
The font used for the Shell Box was not using the shared definition of
mono. This PR replaces the hardcoded value ofMonacowith--mono.With this change, the Shell Box has fonts to fall back to when
Monacoisn't installed on the system (Windows/Linux?).Before
After
Related Issues