X Tutup
The Wayback Machine - https://web.archive.org/web/20201221004758/https://github.com/nodejs/node-core-utils/issues/447
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If last CI is still running, `git node land --yes` should fail #447

Open
mmarchini opened this issue Jun 28, 2020 · 1 comment
Open

If last CI is still running, `git node land --yes` should fail #447

mmarchini opened this issue Jun 28, 2020 · 1 comment

Comments

@mmarchini
Copy link
Member

@mmarchini mmarchini commented Jun 28, 2020

git node land --yes checks will succeed and advance if last CI is still running, which opens the door for landing PRs before we get a result from our CI. We should change it so that if the CI is still running, git node land will fail.

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 26, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup