X Tutup
The Wayback Machine - https://web.archive.org/web/20200814041346/https://github.com/nodejs/nodejs.dev/pull/749
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG Images for Node.js Features #749

Open
wants to merge 7 commits into
base: master
from
Open

Conversation

@ahmadawais
Copy link
Member

ahmadawais commented May 20, 2020

This PR replaces the blurred images on the homepage with free SVG Images from Icons8 using their free license.

BEFORE

image

AFTER (Now with SVG images)

image

P.S. Ignore the button color conflict which has already been handled in #747.

ahmadawais added 2 commits May 20, 2020
@ahmadawais
Copy link
Member Author

ahmadawais commented May 20, 2020

/preview

@github-actions
Copy link

github-actions bot commented May 20, 2020

Please find a preview at: https://staging.nodejs.dev/749/

@ahmadawais ahmadawais requested a review from amiller-gh May 20, 2020
@ahmadawais ahmadawais self-assigned this May 20, 2020
@ahmadawais ahmadawais requested a review from benhalverson May 20, 2020
Copy link
Contributor

benhalverson left a comment

LGTM!

@designMoreWeb
Copy link

designMoreWeb commented May 21, 2020

Can we keep this open ? I think we need to discuss the design changes in the meeting tomorrow

@tstreamDOTh
Copy link
Contributor

tstreamDOTh commented May 21, 2020

Can a line icon be used for the third one (Mentioning Packaging) for consistency ?

@ahmadawais
Copy link
Member Author

ahmadawais commented May 21, 2020

/preview

@github-actions
Copy link

github-actions bot commented May 21, 2020

Please find a preview at: https://staging.nodejs.dev/749/

@amiller-gh
Copy link
Member

amiller-gh commented May 21, 2020

Use inverse green on dark mode – I'll provide new assets so we don't have to worry about licensing 👍

@benhalverson
Copy link
Contributor

benhalverson commented Jun 4, 2020

@amiller-gh Do you have the new assets for the icons?

@saulonunesdev
Copy link
Member

saulonunesdev commented Jun 18, 2020

@ahmadawais please update your PR, we are approving this PR and when we have the new svg files, we will create an issue to update later.

Can you confirm the license of this icons are free to be used?

Copy link
Member

bnb left a comment

Please validate that we do have a license or replace with icons from @amiller-gh / one that we do have licenses for.

@ahmadawais
Copy link
Member Author

ahmadawais commented Jun 18, 2020

This is the licensing of the free icon8 icons
used in this PR. I believe we can find icons with more relaxed licensing than this like @amiller-gh said he will. Feel fee to replace them here. 💯

https://icons8.com/license

@bnb
Copy link
Member

bnb commented Jun 28, 2020

Am I missing something on that page? It's the same page you linked previously and I don't see anything on it that substantiates the assertion that we can use them. Specifically, this section that's titled "open-source" doesn't really clearly define that we can or cannot use them to me, though I could be wrong:

Established open source projects could get the icons for free. For you, we'll opensource the resources that you need.

By established projects we mean the Wikipedia criteria. If you have a page on Wikipedia and it's not removed for a week, you're qualified.

@bnb
Copy link
Member

bnb commented Jun 28, 2020

If you're specifically referring to the free plan, it states this:

Limited for mats in lower resolution. Please link to Icons8 on each page where you use our assets.

I do not see any link back to Icons8 in this PR, which is a polite requirement of the free plan. If I am correct in this, it's concerning that the PR made it this far in scrutiny without realizing that.

Frankly would prefer to avoid linking to external resources like this on the homepage even if the cost of that is not using the resources. Our platform is disproportionately large and I'd strongly play favorites on individual pages (though I do think having a full dependencies page would be beneficial).

Copy link
Member

bnb left a comment

Updating my block to a hard block considering that we're seemingly not technically following the "free" plan of Icons8 correctly.

@benhalverson
Copy link
Contributor

benhalverson commented Jun 28, 2020

ping @amiller-gh Can we get the updated assets?
If not @kodekage would you mind updating your icons to svg.

@designMoreWeb
Copy link

designMoreWeb commented Jul 16, 2020

As @bnb has stated we should just use low resolution svg's and once we have the right assets we can change them, but lets get this issue approved and closed

@bnb
Copy link
Member

bnb commented Jul 16, 2020

@designMoreWeb that is categorically not what I said.

@designMoreWeb
Copy link

designMoreWeb commented Jul 16, 2020

@designMoreWeb that is categorically not what I said.

Tierney, sorry i misunderstood. Could you please clarify what the block is meant to be as i am trying to push and drive this forward

@bnb
Copy link
Member

bnb commented Jul 16, 2020

@designMoreWeb the block quote is a quote from the free licenses page. The current changes don't meet those requirements and, as I stated, I would prefer if we did not go down the path of meeting those.

It would be nice to get clarification/an explicit +1 from them if we meet their guidelines for Open-Source. It would be preferable to have no ambiguity here.

@willin
willin approved these changes Jul 17, 2020
@benhalverson benhalverson dismissed their stale review Jul 17, 2020

Not ready

@ahmadawais
Copy link
Member Author

ahmadawais commented Jul 17, 2020

@bnb I found different MIT licensed icons from HeroIcons. If these look good I can update the PR.

image

Or here's an alternate via SimpleIcons which are Creative Commons Zero v1.0 Universal licensed.

image

@bnb
Copy link
Member

bnb commented Jul 17, 2020

@ahmadawais I think the JS and Open Source logos make sense for JavaScript and Open Source, respectively. Any possibility of using a globe icon for "Everywhere"? Looks like HeroIcons has a globe and whatever the one you used for JavaScript is 👍

@ahmadawais
Copy link
Member Author

ahmadawais commented Jul 17, 2020

That's also what I think but the SimpleIcons has no globe logo. Let me see what we can do.

@benhalverson
Copy link
Contributor

benhalverson commented Jul 30, 2020

/preview

@github-actions
Copy link

github-actions bot commented Jul 30, 2020

Please find a preview at: https://staging.nodejs.dev/749/

@designMoreWeb
Copy link

designMoreWeb commented Jul 30, 2020

Looks great only thing on mobile they look very big in size image

Might need slight resizing but otherwise it's good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.
X Tutup