Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix small issues left in version 4.2.1 #1495
Conversation
samtstern
changed the title
|
Self-review to help out. |
| @@ -92,6 +102,16 @@ public int getPositionForSection(int index) { | |||
|
|
|||
| @Override | |||
| public int getSectionForPosition(int position) { | |||
| if (sections == null) { | |||
samtstern
Oct 23, 2018
Author
Member
Since we were using "fast scrolling" this method had to be implemented to get the scroll bar to work correctly.
lsirac
Oct 24, 2018
Collaborator
I tested this, and it seems a bit jumpy. If you scroll all the way down, and go back up, it immediately jumps to a quarter of the way up. If you can fix that, it'd be perfect. Otherwise, still a big improvement over what we had.
lsirac
Oct 24, 2018
Collaborator
The scrollbar also doesn't show up unless we start scrolling - is that the intended behavior?
samtstern
Oct 24, 2018
Author
Member
Yeah won't show up till you start scrolling, that's normal. There's nothing I can figure out to fix the jumpiness, will maybe look into it again later if people report it.
...ava/com/firebase/ui/auth/viewmodel/PhoneProviderResponseHandlerTest.java
Show resolved
Hide resolved
| targetField = f; | ||
| } | ||
| } | ||
|
|
...ava/com/firebase/ui/auth/viewmodel/PhoneProviderResponseHandlerTest.java
Show resolved
Hide resolved
| @@ -92,6 +102,16 @@ public int getPositionForSection(int index) { | |||
|
|
|||
| @Override | |||
| public int getSectionForPosition(int position) { | |||
| if (sections == null) { | |||
lsirac
Oct 24, 2018
Collaborator
I tested this, and it seems a bit jumpy. If you scroll all the way down, and go back up, it immediately jumps to a quarter of the way up. If you can fix that, it'd be perfect. Otherwise, still a big improvement over what we had.
| @@ -92,6 +102,16 @@ public int getPositionForSection(int index) { | |||
|
|
|||
| @Override | |||
| public int getSectionForPosition(int position) { | |||
| if (sections == null) { | |||
lsirac
Oct 24, 2018
Collaborator
The scrollbar also doesn't show up unless we start scrolling - is that the intended behavior?
|
Going to approve since it's mostly just nits. |
Fixes:
Other changes:
.gradlefiles to make Android Studio pick up the build easier. I got a new computer so I was able to experience the first-timer pain.