X Tutup
The Wayback Machine - https://web.archive.org/web/20220322102450/https://github.com/angular/angularfire/pull/2527
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angular 10 style moduleWithProviders #2527

Merged

Conversation

yasinkocak
Copy link
Contributor

@yasinkocak yasinkocak commented Jun 29, 2020

Checklist

  • Issue number for this PR: #2526

Description

Generic typing ModuleWithProviders

@shadow1349
Copy link

@shadow1349 shadow1349 commented Jun 30, 2020

+1 this is a big blocker for Angular 10 upgrade

@doivosevic
Copy link

@doivosevic doivosevic commented Jul 1, 2020

Where can we track the travis queue and progress? Can we get this in now? It's a blocker

@yasinkocak
Copy link
Contributor Author

@yasinkocak yasinkocak commented Jul 2, 2020

@jamesdaniels is there any action i should do for travis-ci?

@shadow1349
Copy link

@shadow1349 shadow1349 commented Jul 10, 2020

Looks like this is all good, can we get this merged please?

@fritzschoff
Copy link

@fritzschoff fritzschoff commented Jul 15, 2020

For the love of god, just merge it!

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Jul 15, 2020

Hey all, sorry about the delay here. I'd been taking some vacation and just getting back to 6.0 patches this week.

@jamesdaniels jamesdaniels merged commit 93912bc into angular:master Jul 15, 2020
2 checks passed
@marzecm
Copy link

@marzecm marzecm commented Jul 20, 2020

Any idea about new release date? Many thanks ;)

@shadow1349
Copy link

@shadow1349 shadow1349 commented Jul 24, 2020

@marzecm If you want to use it right away you can use the canary build which I've been using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
X Tutup