Expose certain functions used when rolling Flutter #62529
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
willlarche
approved these changes
Jul 30, 2020
Add a comment explaining that so no one accidentally makes them private again.
LGTM!
|
This pull request is not suitable for automatic merging in its current state.
|
Pragya007
added a commit
to Pragya007/flutter
that referenced
this issue
Aug 11, 2020
mingwandroid
added a commit
to mingwandroid/flutter
that referenced
this issue
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


Description
update_icons utility is used in google3 when rolling Flutter. We depend on calling functions explicitly rather than running it as a utility.
Tests
No tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.
The text was updated successfully, but these errors were encountered: