X Tutup
The Wayback Machine - https://web.archive.org/web/20211015090613/https://github.com/flutter/flutter/pull/62529
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose certain functions used when rolling Flutter #62529

Merged
merged 2 commits into from Jul 30, 2020
Merged

Conversation

@mehmetf
Copy link
Member

@mehmetf mehmetf commented Jul 29, 2020

Description

update_icons utility is used in google3 when rolling Flutter. We depend on calling functions explicitly rather than running it as a utility.

Tests

No tests.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Jul 29, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mehmetf mehmetf requested a review from willlarche Jul 29, 2020
Copy link
Member

@willlarche willlarche left a comment

Add a comment explaining that so no one accidentally makes them private again.

LGTM!

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Jul 30, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_tests-4-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mehmetf mehmetf merged commit db2ecf4 into flutter:master Jul 30, 2020
57 of 60 checks passed
mingwandroid added a commit to mingwandroid/flutter that referenced this issue Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup