X Tutup
The Wayback Machine - https://web.archive.org/web/20201110172252/https://github.com/writeas/writefreely/pull/336
Skip to content

/ writefreely

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cache-Control header #336

Merged
merged 2 commits into from Sep 4, 2020
Merged

Add Cache-Control header #336

merged 2 commits into from Sep 4, 2020

Conversation

@Antolius
Copy link
Contributor

@Antolius Antolius commented Jul 21, 2020

Add Cache-Control response header for static files in order to improve page loading speed.
Fixes #322

  • I have signed the CLA
@Antolius
Copy link
Contributor Author

@Antolius Antolius commented Jul 21, 2020

Hi! I'm new to the code-base, so might have missed something obvious, but this seems rather straightforward.

I've also noticed a TODO comment on the InitStaticRoutes method that says it should be converted into a func. If you'd like I can just update the method into something like this:

func InitStaticRoutes(app *App, r *mux.Router)

and leave its implementation as-is.

Or, if the comment had some broader implications I could try working on them as well. For example, it seems like shttp field in the App struct could be removed, in which case the InitStaticRoutes function would not need to modify the app passed into it. This might be a bit bigger change, so it might be better to have it in a separate pull request.
@thebaer
thebaer requested changes Sep 1, 2020
View changes
Copy link
Member

@thebaer thebaer left a comment •
edited

Thanks for looking at this! And sorry for not responding earlier.

Overall, everything looks great! I have just a small suggestion to help keep things organized.

Otherwise, I really appreciate you including a test with these changes. As for that TODO and getting rid of the shttp field, please feel free to submit a separate PR with those changes -- we'd very much welcome those improvements!
cache.go Outdated Show resolved Hide resolved
@thebaer thebaer added this to the 0.13 milestone Sep 1, 2020
Antolius added 2 commits Jul 21, 2020
@Antolius
Add Cache-Control header
3f36ede 
Add Cache-Control response header for static files in order to improve page loading speed.
Fixes  #322
@Antolius
Move cacheControl func into handle.go file
1b1d306
@Antolius Antolius force-pushed the Antolius:static-assets-cache-control branch from 2bda0d8 to 1b1d306 Sep 4, 2020
@thebaer
thebaer approved these changes Sep 4, 2020
View changes
Copy link
Member

@thebaer thebaer left a comment

Awesome, thanks!
@thebaer thebaer merged commit c31a87f into writeas:develop Sep 4, 2020
@Antolius Antolius deleted the Antolius:static-assets-cache-control branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Linked issues

Successfully merging this pull request may close these issues.

static assets served without cache policy leads to suboptimal page speed
2 participants
@Antolius @thebaer
You can’t perform that action at this time.
X Tutup