X Tutup
The Wayback Machine - https://web.archive.org/web/20201204181727/https://github.com/sequelize/sequelize/pull/12547
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): V6 unique composite index upsert #12547

Open
wants to merge 2 commits into
base: v6
from

Conversation

@brianschardt
Copy link

@brianschardt brianschardt commented Jul 24, 2020

Currently updateOnDuplicate for unique index and indexes do not work. This PR solves this issue.

This is following the conversation in this PR: #12516

@codecov
Copy link

@codecov codecov bot commented Jul 24, 2020

Codecov Report

Merging #12547 into v6 will increase coverage by 3.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v6   #12547      +/-   ##
==========================================
+ Coverage   93.42%   96.44%   +3.01%     
==========================================
  Files          91       95       +4     
  Lines        8764     9168     +404     
==========================================
+ Hits         8188     8842     +654     
+ Misses        576      326     -250     
Impacted Files Coverage Δ
lib/model.js 96.59% <91.66%> (-0.04%) ⬇️
lib/dialects/sqlite/query.js 98.18% <0.00%> (ø)
lib/dialects/sqlite/connection-manager.js 100.00% <0.00%> (ø)
lib/dialects/sqlite/query-interface.js 97.02% <0.00%> (ø)
lib/dialects/sqlite/index.js 100.00% <0.00%> (ø)
lib/data-types.js 91.37% <0.00%> (+0.34%) ⬆️
lib/dialects/abstract/query-generator.js 97.39% <0.00%> (+0.50%) ⬆️
lib/dialects/abstract/query-interface.js 94.08% <0.00%> (+0.62%) ⬆️
lib/dialects/abstract/query.js 91.98% <0.00%> (+0.96%) ⬆️
lib/sequelize.js 95.87% <0.00%> (+1.26%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2af0d...7414c70. Read the comment docs.

@brianschardt
Copy link
Author

@brianschardt brianschardt commented Jul 24, 2020

@aecorredor @eseliger can we get this merged in. I am shocked at how such a small change has a long and arduous process. If I can help make things better please let me know.

@aecorredor
Copy link
Contributor

@aecorredor aecorredor commented Jul 24, 2020

I'm not a maintainer so I really don't have much of a say in respect to that.

@aecorredor
Copy link
Contributor

@aecorredor aecorredor commented Jul 29, 2020

@eseliger hey! who would be responsible for getting this approved and merged? Thanks!

@aecorredor
Copy link
Contributor

@aecorredor aecorredor commented Aug 10, 2020

@eseliger any update on this from maintainers? This should be a pretty important issue as bulk updates are pretty common right?

@aecorredor
Copy link
Contributor

@aecorredor aecorredor commented Aug 17, 2020

@papb sorry to bring you into this out of the blue. Just wondering what would the process be for us to get this in. Thanks!

CC: @brianschardt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup