Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: postinstall should not process dev-infra package #19566
Merged
Conversation
devversion
requested review from
jelbourn and
angular/dev-infra-components
as
code owners
devversion
changed the title
|
LGTM |
Currently our NGC postinstall for Bazel also runs against the dev-infra package. This results in a small slow-down and is simply unnecessary given that this does not represent a dependency of interest for `ng_module` compilations.
devversion
force-pushed the
devversion:build/do-not-generate-summaries-dev-infra-pkg
branch
from
aedf90a
to
d6b2b40
andrewseguin
merged commit bde24ed
into
angular:master
15 checks passed
15 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
andrewseguin
added a commit
that referenced
this pull request
Jun 12, 2020
…19566) Currently our NGC postinstall for Bazel also runs against the dev-infra package. This results in a small slow-down and is simply unnecessary given that this does not represent a dependency of interest for `ng_module` compilations.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently our NGC postinstall for Bazel also runs against the
dev-infra package. This results in a small slow-down and is
simply unnecessary given that this does not represent
a dependency of interest for
ng_modulecompilations.