Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating scripts for OTF and WOFF2 #260
Conversation
Adding a few missing glyphs, modifying PL characters for better alignment and resolving issue with Apple's ATSUI API.
Updating the font to resolve a number of open bugs. Also, cleaned up a number of glyphs.
Offsets for subscripts and inferior numbers are set inconsistently. These are now corrected.
Modified the build.py script to add in OTF generation, and also created a second build script that created WOFF2 files from the TTF files (if TSI data removed). Requirements.txt updated to include WOFF2 compression library.
DHowett-MSFT left a comment
|
This looks great! |
|
@DHowett-MSFT I figured you can add the WOFF2 converter to your build script to make things easier for ya :D |
Co-authored-by: Nikolaus Waxweiler <madigens@gmail.com>
|
You may also want to run psautohint over the OTFs like in https://gitlab.gnome.org/GNOME/cantarell-fonts/-/blob/master/scripts/make-static-fonts.py#L38-39 |
|
Added psautohint functionality to the build script and also tried again to clean out the hints from those imported glyphs. I thought I'd gotten them before, but somehow snuck back. |
|
BTW, psautohint was kicking out a whole slew of warnings about 'bogus BBox" I assume partly because of the oddity of the ligatures. Anyway, I filed those away to a "log.txt" file in the build folder. |
|
I think psautohint is a bit anal about that, but I don't know the real value of those warnings. |
|
It seemed to me that the hinting all went through despite the warnings—so I figured they were just for reference rather than any specific blocker. |
|
Derp. I totally forgot that it doesn't just automerge the suggested changes. Alright, I've gone through and fixed those up :) |
aaronbell commentedMay 2, 2020
Summary of the Pull Request
Updated the build.py script to also build OTF versions of the Cascadia Code fonts (in light of the blue zones added!). Additionally added a "build_WOFF.py" script that will process the TTF files in the "build" folder to produce WOFF2 files. Throws an error if VTT production tables present in the fonts.
PR Checklist
Detailed Description of the Pull Request / Additional comments