We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

For context: #20332 and #23015

The reason I think we should expose the interface instead of making it inline as part of the HttpParams structure is because it makes extending HttpParams less complicated. This is the situation where I wanted to use it to work around #11058:

export class PlusSafeQueryEncoder implements HttpParameterCodec {
  encodeKey(key: string): string {
    return encodeURIComponent(key);
  }

  encodeValue(value: string): string {
    return encodeURIComponent(value);
  }

  decodeKey(key: string): string {
    return decodeURIComponent(key);
  }

  decodeValue(value: string): string {
    return decodeURIComponent(value);
  }
}

export class PlusSafeHttpParams extends HttpParams {
  constructor(options?: HttpParamsOptions = {} as HttpParamsOptions) {
    super({ ...options, encoder: new PlusSafeQueryEncoder() })
  }
}

Sounds reasonable to me.

You can always grab the type from the HttpParams constructor, but it still sounds reasonable to use an interface:

type MyHttpParamsOptions = ConstructorParameters<typeof HttpParams>[0];

Started a new presubmit, will keep this thread updated.

FYI, presubmit is successful for the changes in this PR. Thank you.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}