X Tutup
The Wayback Machine - https://web.archive.org/web/20200628004022/https://github.com/angular/angular/issues/35965
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lighthouse in aio to v5.7.0 #35965

Open
IgorMinar opened this issue Mar 9, 2020 · 4 comments
Open

Update lighthouse in aio to v5.7.0 #35965

IgorMinar opened this issue Mar 9, 2020 · 4 comments

Comments

@IgorMinar
Copy link
Member

@IgorMinar IgorMinar commented Mar 9, 2020

this version of lighthouse fixes the issue with img[loading=lazy], see: #34900 (comment)

@IgorMinar IgorMinar created this issue from a note in docs-infra (SELECTED FOR DEVELOPMENT) Mar 9, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 9, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 9, 2020
@sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented Mar 11, 2020

@IgorMinar Does it just need an upgrade in the package.json or is there more to be done here?

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 11, 2020

@sonukapoor, it depends on what has changed in Lighthouse since the currently used version. I usually look through the Lighthouse changelog/release notes and if there are no changes we need (or could benefit from) adapting to, then it is just updating the version in aio.package.json (and aio/yarn.lock).

The script we use to run Lighthouse is aio/scripts/audit-web-app.js, so if other changes are needed it would be in that script.

@sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented Mar 11, 2020

According to @IgorMinar's comment, this is a fix we need. I will try that out.

@sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented Mar 12, 2020

@gkalpak The version 5.7.0 is actually not out yet. I will monitor the package and update the aio/package.json and aio/yarn.lock when it's released. Could you assign this issue to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
docs-infra
SELECTED FOR DEVELOPMENT
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.
X Tutup